Skip to content

Conversation

@limingu
Copy link
Member

@limingu limingu commented Jan 27, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 28, 2023

nginx

@yonzhan yonzhan requested review from jsntcy and kairu-ms January 28, 2023 09:42
@yonzhan yonzhan added this to the Feb 2023 (2023-03-07) milestone Jan 28, 2023
@kairu-ms
Copy link
Contributor

kairu-ms commented Jan 30, 2023

Please pull the latest change in azure-cli repo and record the failed tests in live to fix CI issues. Thanks.

@limingu limingu requested review from kairu-ms and removed request for jsntcy January 31, 2023 01:35
@limingu
Copy link
Member Author

limingu commented Jan 31, 2023

@kairu-ms I updated the test records. Now it passed. Could you please help merge it? Thanks.

@kairu-ms kairu-ms merged commit b111167 into Azure:main Jan 31, 2023
@kairu-ms
Copy link
Contributor

PR merged. If you want to release a new version, please update the version of extension

@limingu limingu deleted the nginx12723 branch January 31, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants