-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AzureContainerApp} fixes Azure/azure-cli-extensions#5781 fix for 'NoneType' object does not support item assignment #5791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ot support item assignment fix for TypeError: 'NoneType' object does not support item assignment while running the `az containerapp dapr enable` command
|
AzureContainerApp |
|
Hi, I've submitted as PR for this problem here: #5782 |
StrawnSC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
could you try to add test for the none type scenario in https://github.com/Azure/azure-cli-extensions/blob/main/src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py#L583 |
Juliehzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure command work
|
@navba-MSFT Could you please resolve these CI issues? |

fixes #5781
fix for TypeError: 'NoneType' object does not support item assignment while running the
az containerapp dapr enablecommandThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.