Skip to content

Conversation

@navba-MSFT
Copy link
Contributor

fixes #5781

fix for TypeError: 'NoneType' object does not support item assignment while running the az containerapp dapr enable command


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

…ot support item assignment

fix for TypeError: 'NoneType' object does not support item assignment while running the `az containerapp dapr enable` command
@ghost ghost requested a review from yonzhan January 19, 2023 09:21
@ghost ghost added the Auto-Assign Auto assign by bot label Jan 19, 2023
@ghost ghost requested a review from wangzelin007 January 19, 2023 09:21
@ghost ghost assigned zhoxing-ms Jan 19, 2023
@ghost ghost added this to the Jan 2023 (2023-02-07) milestone Jan 19, 2023
@ghost ghost added the ContainerApp label Jan 19, 2023
@ghost ghost requested review from jsntcy and zhoxing-ms January 19, 2023 09:21
@navba-MSFT navba-MSFT requested a review from Juliehzl January 19, 2023 09:21
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 19, 2023

AzureContainerApp

@calleo
Copy link
Contributor

calleo commented Jan 22, 2023

Hi, I've submitted as PR for this problem here: #5782

Copy link
Contributor

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get an error when I try to use this code for enabling dapr:
Screen Shot 2023-01-23 at 11 24 25 AM

We should add safe_gets in lines 2371 and 2374 with a default=[] so that we don't get "None type is not iterable" errors

@navba-MSFT navba-MSFT requested a review from StrawnSC January 24, 2023 10:07
@Juliehzl
Copy link
Contributor

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure command work

@zhoxing-ms
Copy link
Contributor

@navba-MSFT Could you please resolve these CI issues?

@navba-MSFT navba-MSFT closed this Feb 2, 2023
@PramodValavala-MSFT PramodValavala-MSFT added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling dapr on an existing container app fails consistently

8 participants