Skip to content

Container app may return null in the dapr object, which cli should handle gracefully #5782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 3 commits into from
Feb 2, 2023
Merged

Container app may return null in the dapr object, which cli should handle gracefully #5782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba6edcf
Dapr object return by Azure API may be null, extend guard such that
calleo Jan 17, 2023
7243993
Update HISTORY.rst
navba-MSFT Feb 1, 2023
111390e
Merge pull request #1 from navba-MSFT/patch-11
calleo Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/containerapp/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
Upcoming
+++++++
* Fix the 'TypeError: 'NoneType' object does not support item assignment' error obtained while running the CLI command 'az containerapp dapr enable'

0.3.21
++++++
* Fix the PermissionError caused for the Temporary files while running `az containerapp up` command on Windows
Expand Down
2 changes: 1 addition & 1 deletion src/containerapp/azext_containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2366,7 +2366,7 @@ def enable_dapr(cmd, name, resource_group_name,
if 'configuration' not in containerapp_def['properties']:
containerapp_def['properties']['configuration'] = {}

if 'dapr' not in containerapp_def['properties']['configuration']:
if not safe_get(containerapp_def['properties']['configuration'], 'dapr'):
containerapp_def['properties']['configuration']['dapr'] = {}
Copy link
Contributor

@Juliehzl Juliehzl Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test in https://github.com/Azure/azure-cli-extensions/blob/main/src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py#L583 and follow the pattern in existing test

Copy link
Contributor Author

@calleo calleo Jan 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added an additional e2e test for this specific scenario. Is there any documentation explaining how to generate the recordings (possibly for a single test). I had to fiddle with scripts/ci/test_source.py to only run the new test method and store the recording. There must be an easier way, but this worked 🙂

@Juliehzl When you get another chance, can you take another look at this PR?


if dapr_app_id:
Expand Down
Loading