[Spring] add --deployment-name for app create #5740
Conversation
|
Spring |
src/spring/azext_spring/_params.py
Outdated
| c.argument('loaded_public_certificate_file', options_list=['--loaded-public-certificate-file', '-f'], type=str, | ||
| help='A json file path indicates the certificates which would be loaded to app') | ||
| c.argument('deployment_name', type=str, | ||
| help='Name of the active deployment. Deployment named "default" will be created if this argument not provided', validator=validate_name) |
There was a problem hiding this comment.
We should use the named argument default="default" to set the default value. With this we don't need to highlight it in the help text.
Check the --sku argument for reference. In the help output, it shows:
--sku : Name of SKU. Enterprise is still in
Preview. Allowed values: Basic,
Enterprise, Standard. Default:
Standard.
There was a problem hiding this comment.
Good point! I will modify the help text as follows:
--deployment-name : Name of the active deployment.
Default: default.
allxiao
left a comment
allxiao
left a comment
There was a problem hiding this comment.
please check the argument spec
src/spring/azext_spring/_params.py
Outdated
| c.argument('loaded_public_certificate_file', options_list=['--loaded-public-certificate-file', '-f'], type=str, | ||
| help='A json file path indicates the certificates which would be loaded to app') | ||
| c.argument('deployment_name', type=str, default='default', | ||
| help='Name of the active deployment.', validator=validate_name) |
There was a problem hiding this comment.
is this active deployment or default deployment? According to line 148 in app.py, this should be default deployment.
There was a problem hiding this comment.
Sure. Will change to default deployment
|
@zhoxing-ms Hi Xing. Would you please help review it again when you are free? Please merge this PR if it is ready to merge. Thanks a lot! |
|
[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=29541&view=results |
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az spring app createcommand add --deployment-name argument.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.