[AKS] Mark AAD-legacy properties deprecated #5670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
assigned
Collaborator
|
AKS |
bingosummer
force-pushed
the
aks-aadv1
branch
from
5261bb7 to
f91a4c0
Compare
bingosummer
requested review from
FumingZhang and
andyliuliming
as code owners
bingosummer
force-pushed
the
aks-aadv1
branch
from
f91a4c0 to
31c9d5d
Compare
FumingZhang
reviewed
Feb 2, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
CI failed due to vm command bump SDK and default API version. Will fix failed test case in some other PR.
Member
Fix PR #5830, please rebase from main after the fix is merged. |
bingosummer
force-pushed
the
aks-aadv1
branch
from
f0ec7d0 to
31c9d5d
Compare
bingosummer
force-pushed
the
aks-aadv1
branch
from
31c9d5d to
df7ef36
Compare
zhoxing-ms
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the parameters
--aad-client-app-id,--aad-server-app-idand--aad-server-app-secretdeprecated. These parameters will be hidden from the output ofaz aks create -h.