Skip to content

Conversation

@clnv
Copy link
Contributor

@clnv clnv commented Nov 7, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms November 7, 2022 02:21
@ghost ghost assigned zhoxing-ms Nov 7, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 7, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 7, 2022
@ghost ghost requested a review from yonzhan November 7, 2022 02:22
@ghost ghost added the AKS label Nov 7, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 7, 2022

AKS

@clnv clnv marked this pull request as ready for review November 7, 2022 03:46
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit f5fb41b into Azure:main Nov 7, 2022
@azclibot
Copy link
Collaborator

azclibot commented Nov 7, 2022

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=13546&view=results

@clnv clnv deleted the fix-aks-preview/agentpool-create-nsg-control branch November 7, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants