Skip to content

Conversation

@clnv
Copy link
Contributor

@clnv clnv commented Oct 19, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create \
  --name ${CLUSTER_NAME} \
  --nodepool-asg-ids ${ASG_0_ID},${ASG_1_ID}
  --nodepool-allowed-host-ports 80/tcp,53/udp,4000-5000/tcp

az aks nodepool add \
  --name ${AGENTPOOL_NAME} \
  --asg-ids ${ASG_0_ID},${ASG_1_ID}
  --allowed-host-ports 80/tcp,53/udp,4000-5000/tcp

az aks nodepool update \
  --name ${AGENTPOOL_NAME} \
  --asg-ids ${ASG_0_ID},${ASG_1_ID}
  --allowed-host-ports 80/tcp,53/udp,4000-5000/tcp

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms October 19, 2022 04:43
@ghost ghost assigned zhoxing-ms Oct 19, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 19, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 19, 2022
@ghost ghost requested a review from yonzhan October 19, 2022 04:43
@ghost ghost added the AKS label Oct 19, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 19, 2022

AKS

@clnv clnv marked this pull request as ready for review October 20, 2022 01:51
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Queued a pipeline to test newly added cases.

@clnv
Copy link
Contributor Author

clnv commented Oct 20, 2022

Queued a pipeline to test newly added cases.

Queued another one for the latest commit. https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=62405154&view=results

@zhoxing-ms zhoxing-ms merged commit 74c32fe into Azure:main Oct 20, 2022
@clnv clnv deleted the nsg-control branch October 20, 2022 06:18
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=10100&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants