Skip to content

Conversation

@t-bzhan
Copy link
Contributor

@t-bzhan t-bzhan commented Oct 17, 2022

Fix managed-rule add issue for Microsoft_DefaultRuleSet with version 2.0 or higher.
This PR aims to fix Azure/azure-cli#24148


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from jsntcy, kairu-ms and yonzhan October 17, 2022 07:06
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 17, 2022
@ghost ghost requested review from necusjz and wangzelin007 October 17, 2022 07:06
@ghost ghost assigned necusjz Oct 17, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 17, 2022
@ghost ghost added the Network label Oct 17, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2022

FrontDoor

@necusjz necusjz merged commit 350d214 into Azure:main Oct 17, 2022
@azclibot
Copy link
Collaborator

azclibot commented Oct 17, 2022

[Release] Update index.json for extension [ front-door ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=9194&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"az network front-door waf-policy managed-rules add" only working for Type DefaultRuleSet Version 1.0

4 participants