Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/spring/HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
Release History
===============
1.1.12
---
* Add warning logs when editing builders and buildpack bindings.

1.1.11
---
* Add command `az spring app deployment enable-remote-debugging`.
Expand Down
6 changes: 6 additions & 0 deletions src/spring/azext_spring/_build_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
import json
from azure.cli.core.util import sdk_no_wait
from .vendored_sdks.appplatform.v2022_01_01_preview import models
from knack.log import get_logger

logger = get_logger(__name__)

DEFAULT_BUILD_SERVICE_NAME = "default"
DEFAULT_BUILD_AGENT_POOL_NAME = "default"
Expand All @@ -25,6 +28,9 @@ def _update_default_build_agent_pool(cmd, client, resource_group, name, build_po


def create_or_update_builder(cmd, client, resource_group, service, name, builder_json=None, builder_file=None, no_wait=False):
logger.warning('Editing builder will regenerate images for all app deployments using this builder. These new images will ' +
'be used after app restart either manually by yourself or automatically by Azure Spring Apps in regular maintenance tasks. ' +
'Use CLI command --"az spring build-service builder show-deployments" to view the app deployment list of the builder.')
builder = _update_builder(builder_file, builder_json)
builder_resource = models.BuilderResource(
properties=builder
Expand Down
6 changes: 6 additions & 0 deletions src/spring/azext_spring/buildpack_binding.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@

def create_or_update_buildpack_binding(cmd, client, resource_group, service,
name, type, builder_name=None, properties=None, secrets=None):
logger.warning('Editing bindings will regenerate images for all app deployments using this builder. These new images will ' +
'be used after app restart either manually by yourself or automatically by Azure Spring Apps in regular maintenance tasks. ' +
'Use CLI command --"az spring build-service builder show-deployments" to view the app deployment list of the builder.')
if not builder_name:
builder_name = DEFAULT_BUILDER_NAME
logger.warning('Option --builder-name is not provided, will use default builder name "{}".'.format(builder_name))
Expand Down Expand Up @@ -52,6 +55,9 @@ def buildpack_binding_list(cmd, client, resource_group, service, builder_name=No


def buildpack_binding_delete(cmd, client, resource_group, service, name, builder_name=None):
logger.warning('Deleting bindings will regenerate images for all app deployments using this builder. These new images will ' +
'be used after app restart either manually by yourself or automatically by Azure Spring Apps in regular maintenance tasks. ' +
'Use CLI command --"az spring build-service builder show-deployments" to view the app deployment list of the builder.')
if not builder_name:
builder_name = DEFAULT_BUILDER_NAME
logger.warning('Option --builder-name is not provided, will use default builder name "{}".'.format(builder_name))
Expand Down
2 changes: 1 addition & 1 deletion src/spring/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.1.11'
VERSION = '1.1.12'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down