Skip to content

Containerapp 0.3.13 Release #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhoxing-ms merged 17 commits into from
Oct 9, 2022
Merged

Containerapp 0.3.13 Release #5426

zhoxing-ms merged 17 commits into from
Oct 9, 2022

Conversation

@StrawnSC
Copy link
Contributor

@StrawnSC StrawnSC commented Oct 7, 2022

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

StrawnSC and others added 6 commits September 14, 2022 10:33
@StrawnSC
bump version
2e3db8a
@runefa @StrawnSC
Custom Domains on Managed Environments (Azure#152)
3665e8b 
* initial no dockerfile support for up

* bump version

* add to help text, history text

* Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)

* pass target port to ACR task; add better error information

* bump version

* fix bug with containerapp create

* add test case

* bump version

* Updated to preview api version and reran all tests. (Azure#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <[email protected]>

Co-authored-by: Haroon Feisal <[email protected]>
Co-authored-by: Silas Strawn <[email protected]>

* resolve anthony's comments

* Revert "`az containerapp up`: Support No Dockerfile Scenario"

* Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""

* Added custom domain support to env create.

* Updated param help group text.

* Added test.

* Wrote env update, wrote test for env update with custom domains.

* Minor update.

* Added help to env update.

Co-authored-by: Silas Strawn <[email protected]>
Co-authored-by: Haroon Feisal <[email protected]>
Fixed style issues.
f38613a
Reran failing tests.
e6a2bce
@pauldotyu
Migrating containerapp-compose into containerapp
bba5c1f
@StrawnSC
bump version
d8dc2c5
@ghost ghost requested a review from yonzhan October 7, 2022 16:42
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 7, 2022
@ghost ghost requested a review from wangzelin007 October 7, 2022 16:42
@ghost ghost assigned zhoxing-ms Oct 7, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 7, 2022
@ghost ghost added the ContainerApp label Oct 7, 2022
@ghost ghost requested review from jsntcy and zhoxing-ms October 7, 2022 16:42
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2022

Containerapp

@StrawnSC StrawnSC marked this pull request as ready for review October 8, 2022 00:46
@StrawnSC StrawnSC mentioned this pull request Oct 8, 2022
Merged
3 tasks
zhoxing-ms
zhoxing-ms reviewed Oct 9, 2022
View reviewed changes
src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py Outdated
@AllowLargeResponse(8192)
@ResourceGroupPreparer(location="australiaeast")
@StorageAccountPreparer(location="australiaeast")
@live_only() # encounters 'CannotOverwriteExistingCassetteException' only when run from recording (passes when run live)
Copy link
Contributor

@zhoxing-ms zhoxing-ms Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask what is the reason for this problem 'CannotOverwriteExistingCassetteException' only when run from recording?

Copy link
Contributor Author

@StrawnSC StrawnSC Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, this test actually passes locally (when run from a recording or live), but fails when run in the CI. Let me try rerecording again to see if it works

Copy link
Contributor Author

@StrawnSC StrawnSC Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just double-checked this with a rerecorded test. The test passes locally, but fails the CI for some reason. I think the best thing to do here is mark it as live_only and investigate further when we have time

Copy link
Contributor

@zhoxing-ms zhoxing-ms Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please remember to submit PR separately to solve the @live_only() problem in the future. It is recommended that you create a work item for these testing problems

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Oct 9, 2022 •
edited
Loading

AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml') in your current record mode ('once').
No match for the request (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.App/managedEnvironments/containerapp-env000003/providers/Microsoft.Insights/diagnosticSettings/diagnosticsettings?api-version=2017-05-01-preview>) was found.
Found 2 similar requests with 1 different matcher(s) :

1 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.App/managedEnvironments/containerapp-env000003/providers/Microsoft.Insights/diagnosticSettings/diagnosticsettings?api-version=2021-05-01-preview>)..)
Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
Matchers failed :
_custom_request_query_matcher - assertion failure :
None

@StrawnSC This is caused by the inconsistent api-version of diagnostic_settings (introduced by PR Azure/azure-cli#23569). It is recommended that you pull the latest CLI code from remote dev branch of main CLI repo and then try to re-record the tests

@zhoxing-ms zhoxing-ms merged commit ca5fffa into Azure:main Oct 9, 2022
@azclibot
Copy link
Collaborator

azclibot commented Oct 9, 2022 •
edited by wangzelin007
Loading

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=7799&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@jsntcy jsntcy Awaiting requested review from jsntcy

@runefa runefa Awaiting requested review from runefa

@panchagnula panchagnula Awaiting requested review from panchagnula

@lil131 lil131 Awaiting requested review from lil131

Assignees

@zhoxing-ms zhoxing-ms

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Milestone

Oct 2022 (2022-11-01)

Development

Successfully merging this pull request may close these issues.

6 participants

@StrawnSC @yonzhan @zhoxing-ms @azclibot @runefa @pauldotyu