Adding an alias(custom-ca-cert) for proxy-cert param for connectedK8s #5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bganapa
reviewed
Oct 6, 2022
bganapa
reviewed
Oct 6, 2022
Collaborator
|
connectedk8s |
bganapa
reviewed
Oct 6, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmpMsft
force-pushed
the
feature/connectedK8s/customCert
branch
from
2fa6cf8 to
fa44465
Compare
pmpMsft
changed the title
sarathys
reviewed
Oct 11, 2022
| c.argument('http_proxy', options_list=['--proxy-http'], arg_group='Proxy', help='Http proxy URL to be used.') | ||
| c.argument('no_proxy', options_list=['--proxy-skip-range'], arg_group='Proxy', help='List of URLs/CIDRs for which proxy should not to be used.') | ||
| c.argument('proxy_cert', options_list=['--proxy-cert'], arg_group='Proxy', type=file_type, completer=FilesCompleter(), help='Path to the certificate file for proxy') | ||
| c.argument('proxy_cert', options_list=['--proxy-cert', '--custom-ca-cert'], arg_group='Proxy', type=file_type, completer=FilesCompleter(), help='Path to the certificate file for proxy or custom Certificate Authority') |
There was a problem hiding this comment.
do we need a new parameter in case user wants to pass in proxy cert and custom ca cert?
Member
There was a problem hiding this comment.
there can be multiple certs combined in one .crt file. Agents code base just accepts one file now. If there is a need, the user will be combining multiple certs in to one file
bganapa
approved these changes
Oct 12, 2022
zhoxing-ms
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.