Skip to content

Conversation

@sushil490023
Copy link
Contributor

@sushil490023 sushil490023 commented Sep 2, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Thank you for your contribution sushil490023! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 2, 2022

automation

@sushil490023 sushil490023 force-pushed the feature-AzureAutomation branch 2 times, most recently from ca96f2b to 2227fa5 Compare September 9, 2022 10:25
@sushil490023 sushil490023 force-pushed the feature-AzureAutomation branch from 2227fa5 to cde2c2f Compare September 9, 2022 10:59
@wangzelin007
Copy link
Member

Hi @sushil490023,
May I ask you to add some scenario tests for those new commands?



@register_command(
"automation python3package create",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate different words with -

Suggested change
"automation python3package create",
"automation python3-package create",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, if we want to expand multiple different package types in the future, could we design this command as automation package create and python3 as one of the valid values of the --package-type parameter?
This design may have better scalability

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed name as suggested

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushil490023 sushil490023 deleted the feature-AzureAutomation branch October 4, 2022 06:29
@sushil490023
Copy link
Contributor Author

Created New PR as was facing issue while generating commands for Python3package. Starting from scratch.

PR : #5415

@sushil490023
Copy link
Contributor Author

@sushil490023
Copy link
Contributor Author

Hi @sushil490023, May I ask you to add some scenario tests for those new commands?

Added scenario test also. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants