-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Python3 CLI Commands #5301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python3 CLI Commands #5301
Conversation
|
Thank you for your contribution sushil490023! We will review the pull request and get back to you soon. |
|
automation |
ca96f2b to
2227fa5
Compare
2227fa5 to
cde2c2f
Compare
|
Hi @sushil490023, |
|
|
||
|
|
||
| @register_command( | ||
| "automation python3package create", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate different words with -
| "automation python3package create", | |
| "automation python3-package create", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, if we want to expand multiple different package types in the future, could we design this command as automation package create and python3 as one of the valid values of the --package-type parameter?
This design may have better scalability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed name as suggested
wangzelin007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Created New PR as was facing issue while generating commands for Python3package. Starting from scratch. PR : #5415 |
Added examples for each commands |
Added scenario test also. Thanks |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.