Skip to content

[NetworkManager] Fix az network manager resources delete behavior #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 4 commits into from
Aug 30, 2022
Merged

[NetworkManager] Fix az network manager resources delete behavior #5285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc6ad93
[NetworkManager] FIx az network manager resources delete behavior
ZengTaoxu Aug 30, 2022
3d14c64
Update src/network-manager/HISTORY.rst
necusjz Aug 30, 2022
01e7986
Update HISTORY.rst
ZengTaoxu Aug 30, 2022
4db7131
Merge branch 'network-manager-05' of https://github.com/ZengTaoxu/azu…
ZengTaoxu Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/network-manager/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
0.5.3
+++++
* Fix force delete behavior.

0.5.2
+++++
* 'az network manager connection management-group': reopen the set of commands.
Expand Down
24 changes: 12 additions & 12 deletions src/network-manager/azext_network_manager/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ def network_manager_update(instance,
def network_manager_delete(client,
resource_group_name,
network_manager_name,
force=None):
if force is None or force is False:
force=False):
if force is False:
print("The \'--force\' flag was not provided for the delete operation. "
"If this resource or any of its child resources are part of a deployed configuration, "
"this delete will fail.")
Expand Down Expand Up @@ -328,8 +328,8 @@ def network_manager_connect_config_delete(client,
resource_group_name,
network_manager_name,
configuration_name,
force=None):
if force is None or force is False:
force=False):
if force is False:
print("The \'--force\' flag was not provided for the delete operation. "
"If this resource or any of its child resources are part of a deployed configuration, "
"this delete will fail.")
Expand Down Expand Up @@ -395,8 +395,8 @@ def network_manager_group_delete(client,
resource_group_name,
network_manager_name,
network_group_name,
force=None):
if force is None or force is False:
force=False):
if force is False:
print("The \'--force\' flag was not provided for the delete operation. "
"If this resource or any of its child resources are part of a deployed configuration, "
"this delete will fail.")
Expand Down Expand Up @@ -534,8 +534,8 @@ def network_manager_security_admin_config_delete(client,
resource_group_name,
network_manager_name,
configuration_name,
force=None):
if force is None or force is False:
force=False):
if force is False:
print("The \'--force\' flag was not provided for the delete operation. "
"If this resource or any of its child resources are part of a deployed configuration, "
"this delete will fail.")
Expand Down Expand Up @@ -610,8 +610,8 @@ def network_manager_admin_rule_collection_delete(client,
network_manager_name,
configuration_name,
rule_collection_name,
force=None):
if force is None or force is False:
force=False):
if force is False:
print("The \'--force\' flag was not provided for the delete operation. "
"If this resource or any of its child resources are part of a deployed configuration, "
"this delete will fail.")
Expand Down Expand Up @@ -740,8 +740,8 @@ def network_manager_admin_rule_delete(client,
configuration_name,
rule_collection_name,
rule_name,
force=None):
if force is None or force is False:
force=False):
if force is False:
print("The \'--force\' flag was not provided for the delete operation. "
"If this resource or any of its child resources are part of a deployed configuration, "
"this delete will fail.")
Expand Down
2 changes: 1 addition & 1 deletion src/network-manager/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from setuptools import setup, find_packages

# HISTORY.rst entry.
VERSION = '0.5.2'
VERSION = '0.5.3'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down