Skip to content

added support for handling success responses on create resources #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 2 commits into from
Aug 25, 2022
Merged

added support for handling success responses on create resources #5273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd9e33
added support for handling success response
krmanupa Aug 25, 2022
86b057d
moved history text to the top
krmanupa Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/automation/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@ Release History
++++++
* Added Hybrid Runbook worker move command.

0.1.4
++++++
* Added handling for success responses on create resources.

@zhoxing-ms zhoxing-ms Aug 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the history of new version to the top of the HISTORY.rst file, such as https://github.com/Azure/azure-cli-extensions/blob/main/src/spring/HISTORY.md


2 changes: 1 addition & 1 deletion src/automation/azext_automation/aaz/latest/automation/hrwg/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class HybridRunbookWorkerGroupCreate(AAZHttpOperation):
def __call__(self, *args, **kwargs):
request = self.make_request()
session = self.client.send_request(request=request, stream=False, **kwargs)
if session.http_response.status_code in [201]:
if session.http_response.status_code in [200, 201]:
return self.on_201(session)

return self.on_error(session.http_response)
Expand Down
2 changes: 1 addition & 1 deletion src/automation/azext_automation/aaz/latest/automation/hrwg/hrw/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class HybridRunbookWorkersCreate(AAZHttpOperation):
def __call__(self, *args, **kwargs):
request = self.make_request()
session = self.client.send_request(request=request, stream=False, **kwargs)
if session.http_response.status_code in [200]:
if session.http_response.status_code in [200, 201]:
return self.on_200(session)

return self.on_error(session.http_response)
Expand Down
Loading