Skip to content

Conversation

@necusjz
Copy link
Member

@necusjz necusjz commented Aug 15, 2022

Resolves: Azure/azure-cli#23429

"Basically, attaching a management IP configuration should only be possible one time, at firewall creation time, and it requires both types of ip-config in one PUT call."
"Azure Firewall has a management IP configuration set but no public IP configurations for data traffic."


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az network firewall create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan August 15, 2022 08:09
@necusjz necusjz self-assigned this Aug 15, 2022
@necusjz necusjz added this to the Aug 2022 (2022-09-06) milestone Aug 15, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 15, 2022
@ghost ghost requested a review from wangzelin007 August 15, 2022 08:09
@ghost ghost added the Network label Aug 15, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 15, 2022

Network

@necusjz necusjz merged commit 435dfcb into Azure:main Aug 16, 2022
@necusjz necusjz deleted the basic-sku-firewall branch August 16, 2022 08:12
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ azure-firewall ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1783697&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For basic Sku firewall we need to make sure we include the Management NIC (Forced tunneling on by default)

4 participants