Skip to content

Conversation

@StrawnSC
Copy link
Contributor

@StrawnSC StrawnSC commented Aug 1, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan August 1, 2022 21:53
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 1, 2022
@ghost ghost requested a review from wangzelin007 August 1, 2022 21:53
@ghost ghost assigned zhoxing-ms Aug 1, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 1, 2022
@ghost ghost added the ContainerApp label Aug 1, 2022
@ghost ghost requested review from jsntcy and zhoxing-ms August 1, 2022 21:53
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 1, 2022

Containerapp

@StrawnSC StrawnSC marked this pull request as ready for review August 12, 2022 01:31
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms
Copy link
Contributor

Could you add some test cases for those change?

@StrawnSC StrawnSC requested a review from zhoxing-ms August 15, 2022 23:25
@StrawnSC StrawnSC requested a review from zhoxing-ms August 16, 2022 05:53
@zhoxing-ms zhoxing-ms merged commit cc90552 into Azure:main Aug 16, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1783567&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants