Update _params.py #5045
Update _params.py #5045
Conversation
remove hard restriction on sku. Leave this to server side for future Premium_P1, Standard_S2
|
webpubsub |
| with self.argument_context('webpubsub create') as c: | ||
| c.argument('sku', arg_type=get_enum_type(SKU_TYPE), help='The sku name of the signalr service.') | ||
| c.argument('unit_count', help='The number of signalr service unit count', type=int) | ||
| c.argument('sku', help='The sku name of the webpubsub service. E.g. Standard_S1') |
There was a problem hiding this comment.
why diable the choice options of sku argument?
There was a problem hiding this comment.
We have SKUs that are internal only. Curretly we don't hope customers outside Microsoft to see those SKUs as they are not allowed to create them. But we hope az cli is available for our internal customers. So we need to remove this restriction from client side and leave it to server side.
There was a problem hiding this comment.
The sku parameter is required for az webpubsub create. Did you mean the customers outside Microsoft are not supposed to run the create command?
There was a problem hiding this comment.
I think we can put all sku available for public in help. But as it's a server-side parameter, I think it doesn't make sense to make restrictions in cli side. We can pass sku parameter to RP side for checking.
There was a problem hiding this comment.
I think we can put all
skuavailable for public inhelp. But as it's a server-side parameter, I think it doesn't make sense to make restrictions in cli side. We can passskuparameter to RP side for checking.
I totally agree
|
@bjqian If you want to release a new version, please create a new PR with extension version updated. |
4 participants
remove hard restriction on sku. Leave this to server side for future Premium_P1, Standard_S2
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az webpubsub
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.