{AKS} Add trusted access roles command #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YitongFeng-git
requested review from
FumingZhang and
andyliuliming
as code owners
Collaborator
|
aks |
karataliu
reviewed
May 17, 2022
karataliu
reviewed
May 17, 2022
karataliu
reviewed
May 17, 2022
YitongFeng-git
force-pushed
the
main
branch
2 times, most recently
from
d0bbf4b to
4ee3224
Compare
FumingZhang
reviewed
May 18, 2022
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
karataliu
reviewed
May 18, 2022
YitongFeng-git
force-pushed
the
main
branch
4 times, most recently
from
4b26eed to
7effbad
Compare
karataliu
reviewed
May 19, 2022
karataliu
reviewed
May 19, 2022
Contributor
karataliu
left a comment
karataliu
left a comment
There was a problem hiding this comment.
left 2 comments, other looks good to me
added 2 commits
May 20, 2022 11:30
karataliu
approved these changes
May 20, 2022
FumingZhang
changed the title
Member
|
I suppose your merge mistakenly overwrites the updated recordings in the main branch. |
Contributor
|
in lates commit test is excluded, and no recording update. any suggest why test failed? @FumingZhang |
Member
|
Failed due to the rebase/merge of main branch was not performed correctly? The commit history of the base branch The commit history of the main branch The key fix commit marked with a red line is not included in the base branch. |
zhoxing-ms
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.