Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Fix the validators for options --min-count and --max-count. Sync the changes from PR #22442.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms May 16, 2022 09:02
@ghost ghost assigned zhoxing-ms May 16, 2022
@ghost ghost added this to the May 2022 (2022-05-24) milestone May 16, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label May 16, 2022
@ghost ghost requested a review from yonzhan May 16, 2022 09:02
@ghost ghost added the AKS label May 16, 2022
@FumingZhang FumingZhang marked this pull request as ready for review May 16, 2022 09:40
@zhoxing-ms zhoxing-ms merged commit 697572b into Azure:main May 16, 2022
@FumingZhang FumingZhang deleted the fuming/fix-validator-for-node-count-0516 branch May 22, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants