{AKS} Add Custom CA Trust to CLI #4782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
assigned
Collaborator
|
aks |
FumingZhang
reviewed
May 7, 2022
UtheMan
force-pushed
the
mikolaj/add-custom-ca-trust
branch
from
af83e72 to
3d2b320
Compare
Member
|
The error msg from Azure.azure-cli-extensions (CLI Linter on Modified Extensions)
To fix, add a new line before line 589 (two lines between functions) and another new line after line 594 (i.e., leave an empty line at the end of a python file). |
FumingZhang
reviewed
May 20, 2022
added 3 commits
May 19, 2022 21:45
FumingZhang
reviewed
May 20, 2022
…o mikolaj/add-custom-ca-trust
…atorManagedClusterModeTestCase to include custom_ca_trust
FumingZhang
reviewed
May 25, 2022
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
approved these changes
May 27, 2022
Contributor
Author
|
Is it looking good? Can we get this merged? :) @zhoxing-ms @FumingZhang |
FumingZhang
added a commit
to FumingZhang/azure-cli-extensions
that referenced
this pull request
Jun 10, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.