Skip to content

Conversation

@KarthikK123
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms May 4, 2022 11:34
@ghost ghost assigned zhoxing-ms May 4, 2022
@ghost ghost added this to the May 2022 (2022-05-24) milestone May 4, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label May 4, 2022
@ghost ghost requested a review from yonzhan May 4, 2022 11:34
@ghost ghost added the AKS label May 4, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 4, 2022

aks

@weinong
Copy link
Contributor

weinong commented May 5, 2022

@FumingZhang PTAL

resource_name: str,
server_fqdn: Optional[str] = None,
format: Optional[Union[str, "_models.Format"]] = None,
namespace_name = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good idea to modify the SDK manually. If this feature is written in swagger, the automatically generated SDK would include the changes. Otherwise, these changes will be erased in the next SDK update (expected to update to 04-02-preview in just a few days).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the changes here and added the namespace sdk generated from the namespace swagger. The namespace swagger is separate from the AKS swagger. Regenerating the AKS sdk will not remove the namespace sdk, will it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK. If the namespace service has python SDK officially released, may use it without vendor the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @norshtein for awareness of modifying the get-credentials command.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FumingZhang
FumingZhang previously approved these changes Jul 11, 2022
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FumingZhang
Copy link
Member

Hey @KarthikK123, could you please clean up the unrelated changes in your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants