Skip to content

Conversation

@renbaoshuo
Copy link
Contributor

All links on git.io will stop redirecting after April 29, 2022.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

All links on git.io will stop redirecting after April 29, 2022.

- https://github.blog/changelog/2022-04-25-git-io-deprecation/
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 27, 2022
@ghost
Copy link

ghost commented Apr 27, 2022

Thank you for your contribution renbaoshuo! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested a review from kairu-ms April 27, 2022 02:46
@yonzhan yonzhan added this to the May 2022 (2022-05-24) milestone Apr 27, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 27, 2022

chore

@kairu-ms
Copy link
Contributor

kairu-ms commented May 5, 2022

@nascarsayan any advice?

@kairu-ms kairu-ms requested a review from nascarsayan May 5, 2022 07:23
@nascarsayan
Copy link
Contributor

nascarsayan commented May 5, 2022

@kairu-ms LGTM. The original repo as changed the short-url too.
https://github.com/mklement0/n-install

Copy link
Contributor

@nascarsayan nascarsayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good.

@kairu-ms kairu-ms merged commit aacce90 into Azure:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants