[Quantum] Add "Microsoft.AzureQuantum-" prefix to deployment name#4657
Merged
necusjz merged 4 commits intoAzure:mainfrom Apr 20, 2022
Merged
Conversation
ghost
added
the
ghost
requested review from
warren-jones
changed the title
Collaborator
|
Quantum |
vxfield
approved these changes
Apr 12, 2022
Member
vxfield
left a comment
vxfield
left a comment
There was a problem hiding this comment.
Approved with some feedback to remove to unused commented lines.
src/quantum/azext_quantum/tests/latest/test_quantum_workspace.py
Outdated
Show resolved
Hide resolved
src/quantum/azext_quantum/tests/latest/test_quantum_workspace.py
Outdated
Show resolved
Hide resolved
vxfield
approved these changes
Apr 12, 2022
Member
vxfield
left a comment
vxfield
left a comment
There was a problem hiding this comment.
Approved with some feedback to remove commented lines
src/quantum/azext_quantum/tests/latest/test_quantum_workspace.py
Outdated
Show resolved
Hide resolved
added 2 commits
April 12, 2022 10:16
george-moussa
approved these changes
Apr 12, 2022
warren-jones
changed the title
necusjz
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To follow our telemetry naming convention and standardize queries, the ARM deployment name should begin with “Microsoft.AzureQuantum-“ when creating a quantum workspace.
This checklist is used to make sure that common guidelines for a pull request are followed.
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?