-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Karenchen/enable draftv2 #4651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Karenchen/enable draftv2 #4651
Changes from 71 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
547441e
starting point
4aacf22
command makes call correctly. Need to reach out to DraftV2
6cd1e00
attempting to download binaries, but headers may be blocking
48ec4bc
Downloading binary, but it's not located in the correct path
a15212e
download into the correct directory works. Need to check existence of…
1eceebf
adding check to ensure download is correct for users os
6f775df
download and run binary
577a65a
fixing msg
cac9fc8
adding copywrite comment
275ea32
addressng PR comments, function naming conventions, etc.
29db02f
fixing copywrite typo
8b05aa4
The linter seems to be complaining about the List type hints. Resolvi…
6e9614c
fixing whitespace. The linter does not seem to like type annotations …
525652a
adding missing whitespaces after ,
c617cef
adding space before operatiors for linter
b6d5e0f
changing type hint import
b9e52b5
more whitespace
8a643e8
adding empty line
3d103b2
removing whitespace from blank linke
e7e9c93
adding disable too many lines
0ef773c
delting draftv2 dir
a52fedb
setup new branch
karenychen 8cc6b05
refactoring
karenychen 6ebaf5e
linked draftv2 create
karenychen 448188f
clean up
karenychen c911b77
rediected stdout and stderr
karenychen f68643b
fixing style checks
karenychen 1b872cf
resolved comments
karenychen 61bdabf
resolved comments
karenychen e6ea3d0
fixed extra imports
karenychen daac6fc
added help menu
karenychen fd314e5
small fix
karenychen df31dbf
style fixes
karenychen 2725913
Merge branch 'main' into karenchen/enable-draftv2
karenychen 85fb982
fixes and added version check
karenychen cc16119
Merge branch 'karenchen/enable-draftv2' of github.com:karenychen/azur…
karenychen 90e216b
quick revert
karenychen 84e693a
quick revert
karenychen 6433574
some refractoring
karenychen 76644f3
renaming functions
karenychen a3eab7e
further refractor
karenychen 3091bdc
quick fixes
karenychen dd5f2b7
more fixes
karenychen 9738354
clean up import statements
karenychen d2febd1
change to use logging
karenychen dca6a1c
name change
karenychen fe44121
more renaming
karenychen bd06547
refractoring
karenychen c458df9
refractoring
karenychen 93f3156
refractoring
karenychen d51b743
refractoring
karenychen bd4a8ef
quick fix
karenychen ce33eca
quick fix
karenychen 5c355d9
remove debug msg
karenychen 6f40dc2
fix version
karenychen 1836550
Karenchen/enable-app-up-draftv2 (#1)
karenychen c6db3c1
Merge branch 'main' into karenchen/enable-draftv2
karenychen c40d9b1
retrigger checks
karenychen 4247f00
Merge branch 'karenchen/enable-draftv2' of github.com:karenychen/azur…
karenychen c2e869a
added help and fixed tests
karenychen b97861c
changing tests
karenychen f8355d0
styling
karenychen 86ad0ac
added auto download for draft binary
karenychen 9807f52
small fixes
karenychen f7d6676
download logic fix
karenychen 11baae4
fixing things
karenychen 4ae096f
fixing tests
karenychen c80cda3
fixing tests
karenychen 74fbf95
fixing recordings
karenychen eadc8ea
added examples in help menu
karenychen efe8c73
added help menu
karenychen 0532e51
changing tests to live only
karenychen 472e2af
fixing concurency tests
karenychen de30662
fixes mkdir issue
karenychen ecd10df
fixes mkdir issue
karenychen 5abea0c
fixes mkdir issue
karenychen 3e5a089
fixes mkdir issue
karenychen a6653e8
fixes download location
karenychen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.