Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Apr 6, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

BugFix: Keep aad profile in PUT request of ManagedCluster. Modified commands are

  • az aks scale
  • az aks upgrade
  • az aks enable-addons
  • az aks disable-addons
  • az aks addon enable
  • az aks addon disable
  • az aks addon update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from wangzelin007 and zhoxing-ms April 6, 2022 09:03
@ghost ghost assigned zhoxing-ms Apr 6, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 6, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 6, 2022
@ghost ghost requested a review from yonzhan April 6, 2022 09:03
@ghost ghost added the AKS label Apr 6, 2022
@FumingZhang FumingZhang force-pushed the fuming/fix-upgrade-missing-aad-profile-0406 branch from 304781e to a6f2086 Compare April 6, 2022 09:05
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 6, 2022

AKS

@FumingZhang FumingZhang changed the title {AKS} Fix aks upgrade, keep aad profile in upgrade request {AKS} Keep aad profile in PUT request of ManagedCluster Apr 7, 2022
@FumingZhang FumingZhang marked this pull request as ready for review April 7, 2022 06:37
@FumingZhang FumingZhang merged commit f2b1fb8 into Azure:main Apr 7, 2022
@FumingZhang FumingZhang deleted the fuming/fix-upgrade-missing-aad-profile-0406 branch May 16, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants