Skip to content

[Quantum] Output job progress messages with Knack logger #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 3 commits into from
Apr 12, 2022
Merged

[Quantum] Output job progress messages with Knack logger #4632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
debcd1d
Output job progress messages with Knack logger
Apr 5, 2022
f228e0a
Update test_version_check
Apr 6, 2022
cc677aa
Update test_version_check again
Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/quantum/azext_quantum/operations/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# pylint: disable=redefined-builtin,bare-except,inconsistent-return-statements

import logging
import knack.log

from azure.cli.core.azclierror import (FileOperationError, AzureInternalError,
InvalidArgumentValueError, AzureResponseError)
Expand All @@ -15,6 +16,7 @@
from .target import TargetInfo

logger = logging.getLogger(__name__)
knack_logger = knack.log.get_logger(__name__)


def list(cmd, resource_group_name=None, workspace_name=None, location=None):
Expand Down Expand Up @@ -70,7 +72,7 @@ def build(cmd, target_id=None, project=None):
logger.debug("Building project with arguments:")
logger.debug(args)

print("Building project...")
knack_logger.warning('Building project...')

import subprocess
result = subprocess.run(args, stdout=subprocess.PIPE, check=False)
Expand Down Expand Up @@ -183,7 +185,7 @@ def submit(cmd, program_args, resource_group_name=None, workspace_name=None, loc
args = _generate_submit_args(program_args, ws, target, token, project, job_name, shots, storage, job_params)
_set_cli_version()

print("Submitting job...")
knack_logger.warning('Submitting job...')

import subprocess
result = subprocess.run(args, stdout=subprocess.PIPE, check=False)
Expand Down
5 changes: 2 additions & 3 deletions src/quantum/azext_quantum/tests/latest/test_quantum_workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,11 @@ def test_version_check(self):

message = check_version(test_config, test_current_reported_version, test_old_date)
assert message is None
# Note: list_versions("quantum") fails during these tests, so latest version number cannot be determined.
# No message is generated if either version number is unavailable.

message = check_version(test_config, test_old_reported_version, test_old_date)
assert message is None
assert message == f"\nVersion {test_old_reported_version} of the quantum extension is installed locally, but version {test_current_reported_version} is now available.\nYou can use 'az extension update -n quantum' to upgrade.\n"

# No message is generated if either version number is unavailable.
message = check_version(test_config, test_none_version, test_today)
assert message is None

Expand Down