Skip to content

Conversation

@wangzelin007
Copy link
Member

@wangzelin007 wangzelin007 commented Mar 15, 2022


  • Bump version to 2021-07-12 stable.
  • Update: host_pool_name max length up to 64 characters long to Fix 19298
  • az desktopvirtualization workspace create Change: --location required to False
  • az desktopvirtualization applicationgroup create Change: --location required to False
  • az desktopvirtualization hostpool create Change --preferred-app-group-type required to True
  • az desktopvirtualization hostpool create Change --personal-desktop-assignment-type required to False
  • az desktopvirtualization hostpool create Change --location required to False
  • az desktopvirtualization hostpool create Add value BYODesktop to --host-pool-type
  • az desktopvirtualization hostpool create Deprecate parameter -sso-context in version 2020-11-10-preview
  • az desktopvirtualization hostpool create Add new parameter --ssoadfs-authority to support WVD SSO certificates
  • az desktopvirtualization hostpool create Add new parameter --sso-client-id to support WVD SSO certificates
  • az desktopvirtualization hostpool create Add new parameter --sso-client-secret-key-vault-path to support WVD SSO certificates
  • az desktopvirtualization hostpool create Add new parameter --sso-secret-type to support WVD SSO certificates
  • az desktopvirtualization hostpool create Add new parameter --preferred-app-group-type to support choosing the type of preferred application group type
  • az desktopvirtualization hostpool create Add new parameter --start-vm-on-connect to support turning on/off StartVMOnConnect feature
  • az desktopvirtualization hostpool update Support parameter --vm-template
  • az desktopvirtualization hostpool update Deprecate parameter -sso-context in version 2020-11-10-preview
  • az desktopvirtualization hostpool update Add new parameter --ssoadfs-authority to support WVD SSO certificates
  • az desktopvirtualization hostpool update Add new parameter --sso-client-id to support WVD SSO certificates
  • az desktopvirtualization hostpool update Add new parameter --sso-client-secret-key-vault-path to support WVD SSO certificates
  • az desktopvirtualization hostpool update Add new parameter --sso-secret-type to support WVD SSO certificates
  • az desktopvirtualization hostpool update Add new parameter --preferred-app-group-type to support choosing the type of preferred application group type
  • az desktopvirtualization hostpool update Add new parameter --start-vm-on-connect to support turning on/off StartVMOnConnect feature
  • az desktopvirtualization hostpool Add command retrieve-registration-token to retrieve registration token

Test screenshot:
image
image

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from yonzhan and zhoxing-ms March 15, 2022 02:53
@ghost ghost added the Auto Assign label Mar 15, 2022
@ghost ghost assigned zhoxing-ms Mar 15, 2022
@ghost ghost added this to the Mar 2022 (2022-04-05) milestone Mar 15, 2022
@ghost ghost added Compute Auto-Assign Auto assign by bot labels Mar 15, 2022
@ghost ghost assigned wangzelin007 Mar 15, 2022
@ghost ghost requested review from jsntcy and kairu-ms March 15, 2022 02:53
@wangzelin007 wangzelin007 removed the request for review from zhoxing-ms March 15, 2022 02:53
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 15, 2022

desktopvirtualization

@wangzelin007 wangzelin007 requested a review from zhoxing-ms March 15, 2022 03:09
@jsntcy
Copy link
Member

jsntcy commented Mar 16, 2022

from azext_desktopvirtualization.manual.version import VERSION

In fact there is no version.py in "manual" folder, so this "import" will not take effect. #Closed


Refers to: src/desktopvirtualization/setup.py:15 in 97a6257. [](commit_id = 97a62579ce0123c406c83f682332d847ab11e26d, deletion_comment = False)

@jsntcy
Copy link
Member

jsntcy commented Mar 16, 2022

from azext_desktopvirtualization.manual.dependency import DEPENDENCIES

Same issue as "version" above. #Closed


Refers to: src/desktopvirtualization/setup.py:36 in 97a6257. [](commit_id = 97a62579ce0123c406c83f682332d847ab11e26d, deletion_comment = False)

@jsntcy
Copy link
Member

jsntcy commented Mar 16, 2022

url='https://github.com/Azure/azure-cli-extensions/tree/master/src/desktopvirtualization',

Should be "main" branch, may need fix codegen logic. #Closed


Refers to: src/desktopvirtualization/setup.py:51 in 97a6257. [](commit_id = 97a62579ce0123c406c83f682332d847ab11e26d, deletion_comment = False)

Copy link
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants