Added distro selection feature#4486
Conversation
|
Thank you for your contribution imabedalghafer! We will review the pull request and get back to you soon. |
|
VM repair |
|
@zhoxing-ms , Would you please let us know the update for the review of this PR ? |
|
@zhoxing-ms The notes have been updated, please let me know if other further updates needed. Thank you :) |
|
@imabedalghafer Could you please resolve those CI issues? |
|
Apologies for the delay , sure I will work on them |
|
@wangzelin007, I have resolved the above CLI errors. would you please check |
|
@wangzelin007 Any update please ? |
Sorry for the late reply, I will merge this PR ASAP. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hi imabedalghafer, May I ask whether it is necessary to add a scenario test for this new argument ? |
|
@wangzelin007 Thank you for the update. |
|
@wangzelin007 Thank you and much appreciate your help |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.