Skip to content

[appservice-kube] Fix #4357, #4358 : support functions v4 and powershell functions #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 6 commits into from
Feb 17, 2022
Merged

[appservice-kube] Fix #4357, #4358 : support functions v4 and powershell functions #4411

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ddf193
support functions v4; powershell functions
StrawnSC Feb 10, 2022
b2d46b4
add custom handler runtime and fix CI issue
StrawnSC Feb 10, 2022
9ebaa6c
use specific error type
StrawnSC Feb 15, 2022
e8d733f
set max CLI version
StrawnSC Feb 16, 2022
627e816
fix CI issues
StrawnSC Feb 16, 2022
dfad462
fix style
StrawnSC Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/appservice-kube/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

0.1.3
++++++
* Update functionapp runtimes and support v4 functionapps

0.1.2
++++++
* Allow passing custom locations by name if in the same resource group as the app/plan
Expand Down
6 changes: 3 additions & 3 deletions src/appservice-kube/azext_appservice_kube/_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
KUBE_FUNCTION_APP_KIND = 'linux,kubernetes,functionapp'
KUBE_FUNCTION_CONTAINER_APP_KIND = 'linux,kubernetes,functionapp,container'

LINUX_RUNTIMES = ['dotnet', 'node', 'python', 'java']
WINDOWS_RUNTIMES = ['dotnet', 'node', 'java', 'powershell']
LINUX_RUNTIMES = ['dotnet', 'node', 'python', 'java', 'powershell', 'dotnet-isolated', 'custom']
Comment thread
StrawnSC marked this conversation as resolved.
WINDOWS_RUNTIMES = ['dotnet', 'node', 'java', 'powershell', 'dotnet-isolated', 'custom']

NODE_VERSION_DEFAULT = "10.14"
NODE_VERSION_NEWER = "12-lts"
Expand All @@ -32,7 +32,7 @@
DOTNET_VERSIONS = ['3.5', '4.7']

LINUX_SKU_DEFAULT = "P1V2"
FUNCTIONS_VERSIONS = ['2', '3']
FUNCTIONS_VERSIONS = ['2', '3', '4']

# functions version : default node version
FUNCTIONS_VERSION_TO_DEFAULT_NODE_VERSION = {
Expand Down
2 changes: 1 addition & 1 deletion src/appservice-kube/azext_appservice_kube/azext_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"azext.isPreview": true,
"azext.minCliCoreVersion": "2.26.0"
"azext.minCliCoreVersion": "2.33.0"
}
2 changes: 1 addition & 1 deletion src/appservice-kube/azext_appservice_kube/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def load_command_table(self, _):
g.custom_command('config-zip', 'enable_zip_deploy_webapp')

with self.command_group('functionapp') as g:
g.custom_command('create', 'create_function', exception_handler=ex_handler_factory())
g.custom_command('create', 'create_functionapp', exception_handler=ex_handler_factory())
g.custom_show_command('show', 'show_webapp', table_transformer=transform_web_output)
g.custom_command('restart', 'restart_webapp')

Expand Down
Loading