Skip to content

Conversation

@Descatles
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan yonzhan requested review from jsntcy and zhoxing-ms December 23, 2021 07:51
@yonzhan yonzhan added this to the Dec 2021 (2022-01-04) milestone Dec 23, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 23, 2021

Spring Cloud

@yonzhan yonzhan requested a review from wangzelin007 December 23, 2021 14:21
Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Descatles,
If you want to release the new extension version, please write the description of changes into HISTORY.rst and update setup.py.

@Descatles
Copy link
Contributor Author

Hi @Descatles, If you want to release the new extension version, please write the description of changes into HISTORY.rst and update setup.py.

Hello, @wangzelin007 , This code change would release together with our enterprise tier cli, we will upgrade the version right before the enterprise tier announcement on 2022/01/17 and release the CLI.
I think we could merge this pr first.

@jsntcy
Copy link
Member

jsntcy commented Dec 27, 2021

Please add test to cover the new argument.

@jsntcy
Copy link
Member

jsntcy commented Dec 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@jsntcy jsntcy merged commit da2e3e1 into Azure:main Dec 27, 2021
@yuwzho yuwzho mentioned this pull request Jan 5, 2022
3 tasks
@yuwzho
Copy link
Contributor

yuwzho commented Jan 5, 2022

#4294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants