[AKS] managed outbound ips should be None if specifying other lb props#4219
Merged
zhoxing-ms merged 12 commits intoAzure:mainfrom Dec 16, 2021
Merged
[AKS] managed outbound ips should be None if specifying other lb props#4219zhoxing-ms merged 12 commits intoAzure:mainfrom
zhoxing-ms merged 12 commits intoAzure:mainfrom
Conversation
FumingZhang
reviewed
Dec 14, 2021
FumingZhang
reviewed
Dec 14, 2021
FumingZhang
reviewed
Dec 14, 2021
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
FumingZhang
reviewed
Dec 14, 2021
Member
|
The PR looks good to me. Please also update version and history, thus we could release a new version to fix the issue. |
3 tasks
FumingZhang
approved these changes
Dec 14, 2021
FumingZhang
approved these changes
Dec 16, 2021
zhoxing-ms
approved these changes
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4205 / Azure/azure-cli#20693 and ensures the managed outbound IP count properties are persisted if only updating
countorcount_ipv6.The base class's version of
configure_load_balancer_profilewill overwrite count ipv6 ifcountis updated, therefore we need to save this value prior to calling the base class and add it back if 1) it is omitted in the current context and 2) outbound IPs and outbound IP prefixes are also omitted.Similarly, if
count_ipv6is being updated, then the previous value ofcountneeds to be saved and added back after the base class is called.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.