Skip to content

[AKS] managed outbound ips should be None if specifying other lb props#4219

Merged
zhoxing-ms merged 12 commits intoAzure:mainfrom
tyler-lloyd:fix-network-lb
Dec 16, 2021
Merged

[AKS] managed outbound ips should be None if specifying other lb props#4219
zhoxing-ms merged 12 commits intoAzure:mainfrom
tyler-lloyd:fix-network-lb

Conversation

@tyler-lloyd
Copy link
Contributor

@tyler-lloyd tyler-lloyd commented Dec 13, 2021


This addresses #4205 / Azure/azure-cli#20693 and ensures the managed outbound IP count properties are persisted if only updating count or count_ipv6.

The base class's version of configure_load_balancer_profile will overwrite count ipv6 if count is updated, therefore we need to save this value prior to calling the base class and add it back if 1) it is omitted in the current context and 2) outbound IPs and outbound IP prefixes are also omitted.

Similarly, if count_ipv6 is being updated, then the previous value of count needs to be saved and added back after the base class is called.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

tyler-lloyd and others added 2 commits December 13, 2021 21:07
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
@FumingZhang
Copy link
Member

FumingZhang commented Dec 14, 2021

The PR looks good to me. Please also update version and history, thus we could release a new version to fix the issue.

@zhoxing-ms zhoxing-ms merged commit 7867fd8 into Azure:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants