Skip to content

{AKS} Refactor 2nd part of the update sub-command in aks-preview module#4204

Merged
zhoxing-ms merged 2 commits intoAzure:mainfrom
FumingZhang:fuming/decorator-update-2
Dec 15, 2021
Merged

{AKS} Refactor 2nd part of the update sub-command in aks-preview module#4204
zhoxing-ms merged 2 commits intoAzure:mainfrom
FumingZhang:fuming/decorator-update-2

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Unit Test Coverage:

"covered_lines": 552,
"num_statements": 554,
"percent_covered": 99.63898916967509,
"missing_lines": 2,
"excluded_lines": 21

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@zhoxing-ms zhoxing-ms self-assigned this Dec 13, 2021
@FumingZhang FumingZhang marked this pull request as ready for review December 15, 2021 02:13
@zhoxing-ms zhoxing-ms merged commit 1b81e53 into Azure:main Dec 15, 2021
@FumingZhang FumingZhang deleted the fuming/decorator-update-2 branch December 29, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants