Quantum CLI extension 0.11.0#4201
Merged
kairu-ms merged 4 commits intoAzure:mainfrom Dec 15, 2021
vxfield:xfield/release/0.11.0
Merged
Quantum CLI extension 0.11.0#4201kairu-ms merged 4 commits intoAzure:mainfrom vxfield:xfield/release/0.11.0
kairu-ms merged 4 commits intoAzure:mainfrom
vxfield:xfield/release/0.11.0
Conversation
Contributor
|
Looks good to me, just waiting for the final build number of the QDK release and the actual date when this is going to be released. |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4201 in repo Azure/azure-cli-extensions |
ricardo-espinoza
approved these changes
Dec 14, 2021
Contributor
|
LGTM, just waiting for approval from the CLI Core team to merge it. |
kairu-ms
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to be reviewed and to be merged on 12/14.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.