Skip to content

Dev/sanmishra/added vm extension support to connectedvmware az cli extension#4124

Merged
zhoxing-ms merged 10 commits intoAzure:mainfrom
iamsantoshmishra-zz:dev/sanmishra/AddedVMExtensionSupportToConnectedvmwareAzCliExtension
Nov 23, 2021
Merged

Dev/sanmishra/added vm extension support to connectedvmware az cli extension#4124
zhoxing-ms merged 10 commits intoAzure:mainfrom
iamsantoshmishra-zz:dev/sanmishra/AddedVMExtensionSupportToConnectedvmwareAzCliExtension

Conversation

@iamsantoshmishra-zz
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2021

connectedvmware

@zhoxing-ms
Copy link
Contributor

Could you add some tests for those changes?

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we can't know the valid values of expand for the time being, and there are other commands in the extension also use --expand, we can keep this design temporarily.

However, I still recommend finding out the valid values of expand, and using these valid values as parameter names to facilitate user's input. Otherwise, users can't know what the values should be passed in for the expand expression, this parameter will not easy for them to use.

As communicated with @93mishra offline, this improvement will be considered and added to the subsequent PR later. So I approve this PR first

@zhoxing-ms zhoxing-ms merged commit 7a0f8b1 into Azure:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants