Dev/sanmishra/added vm extension support to connectedvmware az cli extension#4124
Merged
zhoxing-ms merged 10 commits intoAzure:mainfrom Nov 23, 2021
iamsantoshmishra-zz:dev/sanmishra/AddedVMExtensionSupportToConnectedvmwareAzCliExtension
Merged
Dev/sanmishra/added vm extension support to connectedvmware az cli extension#4124zhoxing-ms merged 10 commits intoAzure:mainfrom iamsantoshmishra-zz:dev/sanmishra/AddedVMExtensionSupportToConnectedvmwareAzCliExtension
zhoxing-ms merged 10 commits intoAzure:mainfrom
iamsantoshmishra-zz:dev/sanmishra/AddedVMExtensionSupportToConnectedvmwareAzCliExtension
Conversation
Collaborator
|
connectedvmware |
…ctedvmwareAzCliExtension
zhoxing-ms
reviewed
Nov 18, 2021
zhoxing-ms
reviewed
Nov 18, 2021
zhoxing-ms
reviewed
Nov 18, 2021
zhoxing-ms
reviewed
Nov 18, 2021
zhoxing-ms
reviewed
Nov 18, 2021
Contributor
|
Could you add some tests for those changes? |
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
zhoxing-ms
reviewed
Nov 22, 2021
zhoxing-ms
reviewed
Nov 22, 2021
zhoxing-ms
approved these changes
Nov 23, 2021
Contributor
There was a problem hiding this comment.
Since we can't know the valid values of expand for the time being, and there are other commands in the extension also use --expand, we can keep this design temporarily.
However, I still recommend finding out the valid values of expand, and using these valid values as parameter names to facilitate user's input. Otherwise, users can't know what the values should be passed in for the expand expression, this parameter will not easy for them to use.
As communicated with @93mishra offline, this improvement will be considered and added to the subsequent PR later. So I approve this PR first
wangzelin007
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.