[Quantum] Do not display update message if version numbers are not available#4110
Merged
kairu-ms merged 2 commits intoAzure:mainfrom Nov 18, 2021
Merged
Conversation
Collaborator
|
Quantum |
warren-jones
changed the title
ricardo-espinoza
approved these changes
Nov 17, 2021
kairu-ms
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to suppress the update message if either version number is not available, and modified the unit tests accordingly.
This bug fix primarily affects the presentation of the update message during testing, and as such will not change the user experience. However, in the rare event of a transient connectivity glitch during version detection, this bug fix has the added benefit of preventing the user from ever seeing a spurious "None" in place of a valid version number in the message.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?