Skip to content

Add warning prompt to private cloud rotate password commands and delete commands#4075

Merged
zhoxing-ms merged 5 commits intoAzure:mainfrom
jonathanhe-msft:jonathanhe/private-cloud-rotate-password
Nov 18, 2021
Merged

Add warning prompt to private cloud rotate password commands and delete commands#4075
zhoxing-ms merged 5 commits intoAzure:mainfrom
jonathanhe-msft:jonathanhe/private-cloud-rotate-password

Conversation

@jonathanhe-msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 5, 2021

vmware

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanhe-msft jonathanhe-msft changed the title Add warning prompt to private cloud rotate password commands Add warning prompt to private cloud rotate password commands and delete commands Nov 15, 2021
@jonathanhe-msft jonathanhe-msft marked this pull request as ready for review November 16, 2021 22:55
@jonathanhe-msft
Copy link
Contributor Author

@zhoxing-ms please review when you get the chance. There will be one additional PR in the future to upgrade to version 4.0.0.

@zhoxing-ms
Copy link
Contributor

Do you need to modify the setup.py to release the new version 4.0.0?

@jonathanhe-msft
Copy link
Contributor Author

Do you need to modify the setup.py to release the new version 4.0.0?

I will create another PR when we are ready to release the new 4.0.0 version with the modifications to setup.py

@zhoxing-ms zhoxing-ms merged commit a144bde into Azure:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants