[SSH] Clean up credentials and support local user login#4065
Merged
jiasli merged 30 commits intoAzure:mainfrom Nov 17, 2021
Merged
[SSH] Clean up credentials and support local user login#4065jiasli merged 30 commits intoAzure:mainfrom
jiasli merged 30 commits intoAzure:mainfrom
Conversation
…ult cred location for config
bagajjal
reviewed
Nov 3, 2021
| VERSION = "1.0.0" | ||
|
|
||
| CLASSIFIERS = [ | ||
| 'Development Status :: 4 - Beta', |
There was a problem hiding this comment.
I think we should change this. With GA, we no longer should say Beta
There was a problem hiding this comment.
Surprised to see the License type is MIT license instead of Microsoft public license (Ms-PL).
Is it a common norm for Az cli to use MIT license?
bagajjal
approved these changes
Nov 3, 2021
Collaborator
|
SSH |
…er to avoid linter error
Add support for connecting to local user on target machine
vthiebaut10
commented
Nov 9, 2021
|
Hello, can someone please approve this PR. IT's been 12 days but there is no response |
jiasli
approved these changes
Nov 16, 2021
bagajjal
reviewed
Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
az ssh config --ip 1.2.3.4 --file /home/user/.ssh/myconfigwill save credentials to the following directory/home/user/.ssh/az_ssh_config/1.2.3.4.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired)Note: There are some style failures related to catching too general exceptions.
Have you run
python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.