Skip to content

{AKS} Update the implementation of aks create to adopt the decorator pattern#4054

Merged
zhoxing-ms merged 2 commits intoAzure:mainfrom
FumingZhang:fuming/switch-to-decorator
Nov 22, 2021
Merged

{AKS} Update the implementation of aks create to adopt the decorator pattern#4054
zhoxing-ms merged 2 commits intoAzure:mainfrom
FumingZhang:fuming/switch-to-decorator

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Update the implementation of aks create to adopt the decorator pattern.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 2, 2021

AKS

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FumingZhang FumingZhang force-pushed the fuming/switch-to-decorator branch 4 times, most recently from 8023c02 to c7b2437 Compare November 10, 2021 07:53
@FumingZhang
Copy link
Member Author

Backward compatibility test results pipeline 1 & pipeline 2.

@FumingZhang FumingZhang force-pushed the fuming/switch-to-decorator branch from c7b2437 to d791bd2 Compare November 15, 2021 02:46
@FumingZhang
Copy link
Member Author

FumingZhang commented Nov 15, 2021

New backward compatibility test:

  • All test cases included by default: result 1
  • Rerun the previously failed test case (attach acr): result 2

aks-preview extended test:

  • All test cases excluded by default: result 1
  • Rerun the previously failed test cases: result 2
  • Rerun the previously failed test case (pod identity): result 3
  • Invalid test case: test_aks_create_with_http_proxy_config

@FumingZhang FumingZhang force-pushed the fuming/switch-to-decorator branch from d791bd2 to 02b10ed Compare November 17, 2021 06:07
@FumingZhang FumingZhang force-pushed the fuming/switch-to-decorator branch from 02b10ed to 5d970b0 Compare November 22, 2021 03:18
@FumingZhang FumingZhang marked this pull request as ready for review November 22, 2021 03:18
@zhoxing-ms zhoxing-ms merged commit b77fbe6 into Azure:main Nov 22, 2021
@FumingZhang FumingZhang deleted the fuming/switch-to-decorator branch November 25, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants