Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"test_aks_nodepool_add_with_ossku"
],
"need additional feature": [
"test_aks_create_enable_encryption",
"test_aks_create_edge_zone",
"test_aks_create_with_auto_upgrade_channel",
"test_aks_enable_openservicemesh_addon",
Expand Down
8 changes: 6 additions & 2 deletions src/aks-preview/azext_aks_preview/decorator.py
Original file line number Diff line number Diff line change
Expand Up @@ -514,20 +514,24 @@ def get_addon_consts(self) -> Dict[str, str]:
from azext_aks_preview._consts import (
ADDONS,
CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME,
CONST_GITOPS_ADDON_NAME,
CONST_ROTATION_POLL_INTERVAL,
CONST_SECRET_ROTATION_ENABLED,
CONST_GITOPS_ADDON_NAME,
CONST_MONITORING_USING_AAD_MSI_AUTH,
)

addon_consts = super().get_addon_consts()
addon_consts["ADDONS"] = ADDONS
addon_consts["CONST_GITOPS_ADDON_NAME"] = CONST_GITOPS_ADDON_NAME
addon_consts[
"CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME"
] = CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME
addon_consts[
"CONST_ROTATION_POLL_INTERVAL"
] = CONST_ROTATION_POLL_INTERVAL
addon_consts[
"CONST_SECRET_ROTATION_ENABLED"
] = CONST_SECRET_ROTATION_ENABLED
addon_consts["CONST_GITOPS_ADDON_NAME"] = CONST_GITOPS_ADDON_NAME
addon_consts[
"CONST_MONITORING_USING_AAD_MSI_AUTH"
] = CONST_MONITORING_USING_AAD_MSI_AUTH
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,7 @@ def test_aks_create_with_openservicemesh_addon(self, resource_group, resource_gr
})

create_cmd = 'aks create --resource-group={resource_group} --name={name} --enable-managed-identity ' \
'--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AKS-OpenServiceMesh ' \
'-a open-service-mesh --ssh-key-value={ssh_key_value} -o json'
self.cmd(create_cmd, checks=[
self.check('provisioningState', 'Succeeded'),
Expand Down
49 changes: 26 additions & 23 deletions src/aks-preview/azext_aks_preview/tests/latest/test_decorator.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,13 @@

from azext_aks_preview.__init__ import register_aks_preview_resource_type
from azext_aks_preview._client_factory import CUSTOM_MGMT_AKS_PREVIEW
from azext_aks_preview.decorator import (
AKSPreviewContext,
AKSPreviewCreateDecorator,
AKSPreviewModels,
AKSPreviewUpdateDecorator,
)
from azext_aks_preview.tests.latest.mocks import MockCLI, MockClient, MockCmd
from azext_aks_preview.tests.latest.test_aks_commands import _get_test_data_file
from azure.cli.command_modules.acs._consts import DecoratorMode
from azure.cli.core.azclierror import (
ArgumentUsageError,
CLIInternalError,
InvalidArgumentValueError,
MutuallyExclusiveArgumentError,
NoTTYError,
RequiredArgumentMissingError,
UnknownError,
)
from azext_aks_preview._consts import (
ADDONS,
CONST_ACC_SGX_QUOTE_HELPER_ENABLED,
CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME,
CONST_AZURE_POLICY_ADDON_NAME,
CONST_CONFCOM_ADDON_NAME,
CONST_GITOPS_ADDON_NAME,
CONST_HTTP_APPLICATION_ROUTING_ADDON_NAME,
CONST_INGRESS_APPGW_ADDON_NAME,
CONST_INGRESS_APPGW_APPLICATION_GATEWAY_ID,
Expand All @@ -42,13 +26,30 @@
CONST_KUBE_DASHBOARD_ADDON_NAME,
CONST_MONITORING_ADDON_NAME,
CONST_MONITORING_LOG_ANALYTICS_WORKSPACE_RESOURCE_ID,
CONST_MONITORING_USING_AAD_MSI_AUTH,
CONST_OPEN_SERVICE_MESH_ADDON_NAME,
CONST_ROTATION_POLL_INTERVAL,
CONST_SECRET_ROTATION_ENABLED,
CONST_VIRTUAL_NODE_ADDON_NAME,
CONST_VIRTUAL_NODE_SUBNET_NAME,
CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME,
CONST_GITOPS_ADDON_NAME,
CONST_SECRET_ROTATION_ENABLED,
CONST_MONITORING_USING_AAD_MSI_AUTH,
)
from azext_aks_preview.decorator import (
AKSPreviewContext,
AKSPreviewCreateDecorator,
AKSPreviewModels,
AKSPreviewUpdateDecorator,
)
from azext_aks_preview.tests.latest.mocks import MockCLI, MockClient, MockCmd
from azext_aks_preview.tests.latest.test_aks_commands import _get_test_data_file
from azure.cli.command_modules.acs._consts import DecoratorMode
from azure.cli.core.azclierror import (
ArgumentUsageError,
CLIInternalError,
InvalidArgumentValueError,
MutuallyExclusiveArgumentError,
NoTTYError,
RequiredArgumentMissingError,
UnknownError,
)


Expand Down Expand Up @@ -516,8 +517,10 @@ def test_get_addon_consts(self):
"CONST_VIRTUAL_NODE_ADDON_NAME": CONST_VIRTUAL_NODE_ADDON_NAME,
"CONST_VIRTUAL_NODE_SUBNET_NAME": CONST_VIRTUAL_NODE_SUBNET_NAME,
"CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME": CONST_AZURE_KEYVAULT_SECRETS_PROVIDER_ADDON_NAME,
"CONST_GITOPS_ADDON_NAME": CONST_GITOPS_ADDON_NAME,
"CONST_SECRET_ROTATION_ENABLED": CONST_SECRET_ROTATION_ENABLED,
"CONST_ROTATION_POLL_INTERVAL": CONST_ROTATION_POLL_INTERVAL,
# new in aks-preview
"CONST_GITOPS_ADDON_NAME": CONST_GITOPS_ADDON_NAME,
"CONST_MONITORING_USING_AAD_MSI_AUTH": CONST_MONITORING_USING_AAD_MSI_AUTH,
}
self.assertEqual(addon_consts, ground_truth_addon_consts)
Expand Down