Skip to content

Conversation

@Caoxuyang
Copy link
Contributor

@Caoxuyang Caoxuyang commented Oct 14, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 14, 2021

spring cloud

@Caoxuyang Caoxuyang marked this pull request as ready for review October 19, 2021 06:15
@Caoxuyang Caoxuyang changed the title [WIP] Support BYOS feature in api version 2021-09-01-preview Support BYOS feature in api version 2021-09-01-preview Oct 19, 2021
@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhoxing-ms
Copy link
Contributor

Please write the change description into HISTORY.md and upgrade the version in setup.py

@zhoxing-ms
Copy link
Contributor

Please add some tests for this new change

@Caoxuyang
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 3961 in repo Azure/azure-cli-extensions

@zhoxing-ms zhoxing-ms merged commit c6f2551 into Azure:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants