Managed cassandra preview commands for cli extension#3948
Managed cassandra preview commands for cli extension#3948evelyn-ys merged 28 commits intoAzure:mainfrom
Conversation
|
cosmosdb |
There was a problem hiding this comment.
Please remove these commands since it will be supported in azure-cli repo.
|
Please add tests for new commands |
|
Since the api version has upgraded, I think you might need to re-record all the existing tests. Run |
There was a problem hiding this comment.
Do you mean cassandra_stop_start by cassandra-stop-start?
|
Please sync from |
There was a problem hiding this comment.
There's no backups command, only backup command group and backup list/backup show command.
There was a problem hiding this comment.
When this if condition is not met, data_center_properties.authentication_method_ldap_properties is not set at all, but still the serialized payload contains data_center_properties.authentication_method_ldap_properties as {}
Instead I expect authentication_method_ldap_properties key not to be part of the payload itself.
There was a problem hiding this comment.
These commands have already been in main CLI, why add them in extension again?
There was a problem hiding this comment.
Generally we will design CLI commands like managed0cassandra cluster backup list
There was a problem hiding this comment.
Same here managed-cassandra cluster backup show
There was a problem hiding this comment.
| 'managed-cassandra cluster backup-list']: | |
| 'managed-cassandra cluster backup-list', | |
| 'managed-cassandra cluster backup-show']: |
Does backup-show share the same definition of cluster_name param? If so, you should add backup-show in the list too.
There was a problem hiding this comment.
| g.custom_command('backup-list', 'cli_cosmosdb_managed_cassandra_cluster_list_backup', is_preview=True) | |
| g.custom_command('backup-show', 'cli_cosmosdb_managed_cassandra_cluster_show_backup', is_preview=True) | |
| g.custom_command('backup list', 'cli_cosmosdb_managed_cassandra_cluster_list_backup', is_preview=True) | |
| g.custom_command('backup show', 'cli_cosmosdb_managed_cassandra_cluster_show_backup', is_preview=True) |
Better to change them to backup list and backup show like all other commands.
dcd0c46 to
f701de0
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.