Skip to content

Conversation

@Bhuvaneswari-Santharam
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 17, 2021

aks

@FumingZhang
Copy link
Member

mock has been replaced with unittest.mock in this PR #19024.

@bganapa bganapa self-requested a review September 21, 2021 17:59
@zhoxing-ms
Copy link
Contributor

@Bhuvaneswari-Santharam Could you please address those CI issues

@zhoxing-ms
Copy link
Contributor

Please write those changes into the HISTORY.rst

By the way, do you need to release a new version for these changes? If so, please also update the setup.py

@FumingZhang
Copy link
Member

It seems that the reason for the failure of CI is that the test is not executed using the 2020-09-01-hybrid profile. I read the code about the CI part, and it seems that testing of profiles other than the default profile (latest) is not supported?

@zhoxing-ms
Copy link
Contributor

@Bhuvaneswari-Santharam Any update?

@zhoxing-ms
Copy link
Contributor

It seems that the reason for the failure of CI is that the test is not executed using the 2020-09-01-hybrid profile. I read the code about the CI part, and it seems that testing of profiles other than the default profile (latest) is not supported?

Yes, our pipeline does not support testing other profiles at present

Generally, our extension does not support multiple profiles. Because the feature of old profile are always stable, it is more recommended to put it in the main CLI. If both extension and main CLI support multiple profiles, more unnecessary maintenance costs will be introduced.
As discussed with @FumingZhang, these features for old profile will be included in the main CLI after they complete the reconstruction in AKS module.
So this PR doesn't seem to be needed anymore. @Bhuvaneswari-Santharam May I ask what is your opinion on this?

@Bhuvaneswari-Santharam
Copy link
Member Author

We are trying to integrate az kollect and az kanalyze commands into hybrid profile, we already completed work on aks periscope for Azure stack. @FumingZhang - Will these commands also be supported in CLI as part of reconstruction work or remain as part of extension? If these commands will remain as part of extension we need these hybrid profile integration in extensions

@FumingZhang
Copy link
Member

Hi @Bhuvaneswari-Santharam , let me confirm with PM/feature owner whether we would migrate kollect and kanalyze sub-commands to acs in azure-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants