-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding hybrid profile for aks-preview #3901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding hybrid profile for aks-preview #3901
Conversation
|
aks |
|
|
|
@Bhuvaneswari-Santharam Could you please address those CI issues |
|
Please write those changes into the By the way, do you need to release a new version for these changes? If so, please also update the |
|
It seems that the reason for the failure of CI is that the test is not executed using the |
|
@Bhuvaneswari-Santharam Any update? |
Yes, our pipeline does not support testing other profiles at present Generally, our extension does not support multiple profiles. Because the feature of old profile are always stable, it is more recommended to put it in the main CLI. If both extension and main CLI support multiple profiles, more unnecessary maintenance costs will be introduced. |
|
We are trying to integrate az kollect and az kanalyze commands into hybrid profile, we already completed work on aks periscope for Azure stack. @FumingZhang - Will these commands also be supported in CLI as part of reconstruction work or remain as part of extension? If these commands will remain as part of extension we need these hybrid profile integration in extensions |
|
Hi @Bhuvaneswari-Santharam , let me confirm with PM/feature owner whether we would migrate |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.