[vm-repair] Bug fix for disk copy V2 to V1 and Adding preview parameter

[haagha]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[yonzhan]

vm-repair

[zhoxing-ms]

@haagha Could you add some tests for this case?

[zhoxing-ms]

Please write those changes into the HISTORY.rst

By the way, do you need to release a new version for these changes? If so, please also update the setup.py

[zhoxing-ms]

@haagha Any update?

[haagha]

@zhoxing-ms Yes i updated the history and build version. Will try to fix the CI failures.

[zhoxing-ms]

@haagha Please address those CI issues~

[haagha]

@zhoxing-ms Can you check why the integration tests not related to vm-repair are failing?

[zhoxing-ms]

I see the following problems in CI failure:

1. Static Analysis

/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/custom.py:55:9: F841 local variable 'is_gen2' is assigned to but never used
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/custom.py:72:9: E265 block comment should start with '# '
1 E265 block comment should start with '# '
1 F841 local variable 'is_gen2' is assigned to but never used

@haagha Please follow the tips of error message to modify your code

2. Integration test

======================================================================
FAIL: test_NewExtensionMultiNic (azext_aem.tests.latest.test_aem_commands.VMAEM)

Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/azure/cli/testsdk/base.py", line 293, in _in_process_execute
self.exit_code = cli_ctx.invoke(shlex.split(command), out_file=stdout_buf) or 0
File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/knack/cli.py", line 243, in invoke
exit_code = self.exception_handler(ex)
File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/azure/cli/core/init.py", line 137, in exception_handler
return handle_exception(ex)
File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/azure/cli/testsdk/patches.py", line 33, in _handle_main_exception
raise ex
File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/knack/cli.py", line 231, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/azure/cli/core/commands/init.py", line 657, in execute
raise ex
vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/home/vsts/work/1/s/src/aem/azext_aem/tests/latest/recordings/test_NewExtensionMultiNic.yaml') in your current record mode ('once').
No match for the request (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/vnet1?api-version=2021-03-01>) was found.
Found 2 similar requests with 1 different matcher(s) :

1 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/vnet1?api-version=2021-02-01>).
Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
Matchers failed :
_custom_request_query_matcher - assertion failure :
None

2 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/vnet1?api-version=2021-02-01>).
Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
Matchers failed :

@kairu-ms @00Kai0 Please take a look. This should be related to the api-version bumping of network Azure/azure-cli#19590

[kairu-ms]

@haagha Please pull the change in latest main branch.

[haagha]

@zhoxing-ms Can you review this, thanks!

[zhoxing-ms]

Could you add some tests for this change?

[zhoxing-ms]

@haagha Any update?

[haagha]

@zhoxing-ms Removed comment and added test.