Skip to content

Conversation

@calvinsID
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@calvinsID calvinsID requested a review from panchagnula as a code owner July 29, 2021 18:55
@yonzhan yonzhan requested a review from zhoxing-ms July 29, 2021 22:32
@yonzhan yonzhan requested review from Juliehzl and jsntcy July 29, 2021 22:32
@yonzhan yonzhan added this to the Jul 2021 (2021-08-03) milestone Jul 29, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2021

webapp

@calvinsID calvinsID force-pushed the update-webapp-extension branch from ad0334e to 629537b Compare July 29, 2021 22:52
@calvinsID calvinsID force-pushed the update-webapp-extension branch from 8cdfda8 to 74a7640 Compare July 29, 2021 23:15
@panchagnula
Copy link
Contributor

@calvinsID looks like we need to add an entry here "Exception: No entry of webapp in service_name.json. Please add one to the file."

Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panchagnula panchagnula merged commit bf4b942 into Azure:main Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants