[interactive] Fix #17740: az interactive fails with progress_patch() got an unexpected keyword argument 'det'#3636
Merged
Juliehzl merged 3 commits intoAzure:mainfrom Jul 15, 2021
Merged
Conversation
Collaborator
|
aks |
jiasli
reviewed
Jul 13, 2021
jiasli
reviewed
Jul 13, 2021
az interactive fails with progress_patch() got an unexpected keyword argument 'det'
jiasli
approved these changes
Jul 13, 2021
Member
|
Good work. 🚢 |
Member
|
Why are chances reverted? |
Contributor
Author
rebase main branch to make sure correct incremental test detection. Otherwise, there will be some test failures. |
Member
|
You didn't pull before rebasing, causing changes from code review (d67a86db3fbdd37126d1e23b83b84df07879a1f3) to be lost. |
Contributor
Author
Thanks for the check. Add back now. |
jiasli
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Fix Azure/azure-cli#17740
As progress_patch() will raise exception when specifying det=xx, we change progress_patch() to accept key-value pairs.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.