Skip to content

[interactive] Fix #17740: az interactive fails with progress_patch() got an unexpected keyword argument 'det'#3636

Merged
Juliehzl merged 3 commits intoAzure:mainfrom
Juliehzl:fix17740
Jul 15, 2021
Merged

[interactive] Fix #17740: az interactive fails with progress_patch() got an unexpected keyword argument 'det'#3636
Juliehzl merged 3 commits intoAzure:mainfrom
Juliehzl:fix17740

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Jul 13, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.
Fix Azure/azure-cli#17740
As progress_patch() will raise exception when specifying det=xx, we change progress_patch() to accept key-value pairs.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@Juliehzl Juliehzl requested a review from jiasli as a code owner July 13, 2021 03:23
@Juliehzl Juliehzl requested a review from zhoxing-ms July 13, 2021 03:24
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 13, 2021

aks

@yonzhan yonzhan added this to the Jul 2021 (2021-08-03) milestone Jul 13, 2021
@jiasli jiasli changed the title [interactive] Fix issue "az aks create" fails with "progress_patch() got an unexpected keyword argument 'det'". [interactive] Fix #17740: az interactive fails with progress_patch() got an unexpected keyword argument 'det' Jul 13, 2021
@jiasli
Copy link
Member

jiasli commented Jul 13, 2021

Good work. 🚢

@jiasli
Copy link
Member

jiasli commented Jul 14, 2021

Why are chances reverted?

@Juliehzl
Copy link
Contributor Author

Why are chances reverted?

rebase main branch to make sure correct incremental test detection. Otherwise, there will be some test failures.

@jiasli
Copy link
Member

jiasli commented Jul 14, 2021

You didn't pull before rebasing, causing changes from code review (d67a86db3fbdd37126d1e23b83b84df07879a1f3) to be lost.

@Juliehzl
Copy link
Contributor Author

code review (d67a86d)

Thanks for the check. Add back now.

@Juliehzl Juliehzl merged commit 5ac3cdb into Azure:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"az aks create" fails with "progress_patch() got an unexpected keyword argument 'det'".

3 participants