Skip to content

[Virtual Wan] Fix get-effective-routes unavailable after migrationg to track2 sdk #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsntcy merged 4 commits into from
Aug 3, 2021
Merged

[Virtual Wan] Fix get-effective-routes unavailable after migrationg to track2 sdk #3555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4fa9c4
fix get-effective-routes unavailable after migrationg to track2 sdk
00Kai0 Jun 28, 2021
18ccbbb
Merge remote-tracking branch 'origin/main' into kaihui-fix-get-effect…
00Kai0 Aug 2, 2021
a80166c
update recording
00Kai0 Aug 2, 2021
e18bfb3
update version and changelog
00Kai0 Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/virtual-wan/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Release History
===============

0.2.7
++++++
* bugfix: `az network vhub get-effective-routes` always returns empty value list.

0.2.6
++++++
* `az network vhub get-effective-routes` support `-o table` outputs.
Expand Down
4 changes: 2 additions & 2 deletions src/virtual-wan/azext_vwan/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,11 @@ def create_virtual_hub(cmd, resource_group_name, virtual_hub_name, address_prefi
def get_effective_virtual_hub_routes(cmd, resource_group_name, virtual_hub_name,
virtual_wan_resource_type=None, resource_id=None, no_wait=False):
parameters = None
Resource, EffectiveRoutesParameters = cmd.get_models("Resource", 'EffectiveRoutesParameters')
EffectiveRoutesParameters = cmd.get_models('EffectiveRoutesParameters')
if virtual_wan_resource_type is not None or resource_id is not None:
parameters = EffectiveRoutesParameters(
virtual_wan_resource_type=virtual_wan_resource_type,
resource_id=Resource(id=resource_id)
resource_id=resource_id
)

client = network_client_factory(cmd.cli_ctx).virtual_hubs
Expand Down
1,249 changes: 629 additions & 620 deletions ...ual-wan/azext_vwan/tests/latest/recordings/test_azure_p2s_vpn_gateway_basic_scenario.yaml
View file
Open in desktop

Large diffs are not rendered by default.

465 changes: 306 additions & 159 deletions ...ual-wan/azext_vwan/tests/latest/recordings/test_azure_vhub_connection_basic_scenario.yaml
View file
Open in desktop

Large diffs are not rendered by default.

409 changes: 197 additions & 212 deletions ...l-wan/azext_vwan/tests/latest/recordings/test_azure_vpn_server_config_basic_scenario.yaml
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions ...rtual-wan/azext_vwan/tests/latest/recordings/test_azure_vpn_server_config_multi_auth.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ interactions:
accept-language:
- en-US
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_azure_vpn_server_config_multi_auth000001?api-version=2020-10-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_azure_vpn_server_config_multi_auth000001?api-version=2021-04-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_azure_vpn_server_config_multi_auth000001","name":"test_azure_vpn_server_config_multi_auth000001","type":"Microsoft.Resources/resourceGroups","location":"westcentralus","tags":{"product":"azurecli","cause":"automation","date":"2021-04-15T09:49:25Z"},"properties":{"provisioningState":"Succeeded"}}'
Expand Down Expand Up @@ -268,7 +268,7 @@ interactions:
accept-language:
- en-US
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_azure_vpn_server_config_multi_auth000001?api-version=2020-10-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_azure_vpn_server_config_multi_auth000001?api-version=2021-04-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_azure_vpn_server_config_multi_auth000001","name":"test_azure_vpn_server_config_multi_auth000001","type":"Microsoft.Resources/resourceGroups","location":"westcentralus","tags":{"product":"azurecli","cause":"automation","date":"2021-04-15T09:49:25Z"},"properties":{"provisioningState":"Succeeded"}}'
Expand Down Expand Up @@ -499,7 +499,7 @@ interactions:
accept-language:
- en-US
method: GET
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_azure_vpn_server_config_multi_auth000001?api-version=2020-10-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_azure_vpn_server_config_multi_auth000001?api-version=2021-04-01
response:
body:
string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_azure_vpn_server_config_multi_auth000001","name":"test_azure_vpn_server_config_multi_auth000001","type":"Microsoft.Resources/resourceGroups","location":"westcentralus","tags":{"product":"azurecli","cause":"automation","date":"2021-04-15T09:49:25Z"},"properties":{"provisioningState":"Succeeded"}}'
Expand Down
Loading