-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Set version to 0.3.6 #3518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set version to 0.3.6 #3518
Conversation
This update is necessary for PR #3153
|
vm repair |
|
There is the following buildlog error --> which needs to be further investigated |
|
Please add entry for your extension commands in https://github.com/Azure/azure-cli-extensions/blob/9f0aa09e7652ee73b4d75fab064711e78fb99ab8/src/service_name.json. And you need to update history.rst for release note |
|
Service_name.py needs no change. Just added some line to the existing vm-repair extension. |
|
service_name.json is used to generate document, if you don't update it, CI will always fail |
|
@malachma Please add the description of your modification to |
|
HISTORY.rst is not used with vm-repair. If you look in setup.py you don't see it used compared with other extensions. |
|
@malachma Hi, in fact, |
|
By the way, please also add the description of command {
"Command": "az vm",
"AzureServiceName": "Azure Virtual Machines",
"URL": "https://docs.microsoft.com/en-us/azure/virtual-machines/"
} |
|
This last update I do not understand. It looks to me that your have a general build issue which is not caused by this PR. |
|
@malachma Add this just to let your PR pass CI CI issue:
|
|
|
|
@malachma May I ask what's the update here? |
…setup-cloud-init.txt"
fixed the linter complain about a missing newline
|
Sorry for the delay. I had been busy on other projects and where a couple of days off too. |
This update is necessary for PR #3153
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.