Migrate instrumentation_key to connection_string for spring-cloud extension #3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customer-reported
|
Thank you for your contribution ECNUJason! We will review the pull request and get back to you soon. |
Collaborator
|
spring cloud |
…tation key to connection string, fall back to instrumentation key when connection string is not available
jiec-msft
commented
Jun 8, 2021
jiec-msft
commented
Jun 8, 2021
Collaborator
|
Add @kairu-ms for awareness |
jiec-msft
commented
Jun 8, 2021
zhoxing-ms
reviewed
Jun 8, 2021
Contributor
|
Could you add some tests for the feature change? |
kairu-ms
reviewed
Jun 16, 2021
Contributor
kairu-ms
left a comment
kairu-ms
left a comment
There was a problem hiding this comment.
The sdk version of app-insights already update to 1.0.0 in latest cli. Please update azext.minCliCoreVersion to the latest cli version
by transforming 'intrumentation key' to 'connection string'; 3. Use concret type of exception to replace general CLIError; 4. fix typo for connection; 5. Add unit test;
Contributor
Author
Updated to |
Contributor
Author
Sure, added. |
zhoxing-ms
approved these changes
Jun 17, 2021
ShichaoQiu
approved these changes
Jun 18, 2021
zhoxing-ms
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Revert "Migrate instrumentation_key to connection_string for spring-cloud extension (#3467)" This reverts commit 097827a * Add release note and set version Co-authored-by: Mason(Jie) Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extension: Spring-Cloud Application-Insights, migration instrumentation key to connection string, fall back to instrumentation key when connection string is not available
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.