Conversation
memontic-ms
force-pushed
the
communication-ga-release
branch
from
633ebe1 to
128d4ab
Compare
|
Communication |
|
Top-level subgroups are now 'service' and 'status'. Not sure if this is intended. This makes it so that |
|
Need help getting the tests to pass |
memontic-ms
force-pushed
the
communication-ga-release
branch
from
128d4ab to
bdd8684
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@memontic-ms Please rebase your branch on latest master branch. |
memontic-ms
force-pushed
the
communication-ga-release
branch
from
bdd8684 to
f387f75
Compare
|
@memontic-ms Please fix test issues. |
There was a problem hiding this comment.
I think communicationservice has prefix communication which is duplicated with parent command group name. Why not rename it to service as a short?
There was a problem hiding this comment.
I don't know what the guidelines for the naming is. I didn't make any customizations since the initial version, so I don't know why this generated differently. What should this look like? How can I get it to generate with the correct command names?
There was a problem hiding this comment.
Could you please share your swagger link and codegen configuration?
memontic-ms
force-pushed
the
communication-ga-release
branch
from
f387f75 to
2b30be3
Compare
|
I regenerated based on the suggestions from @kairu-ms This version looks a little better and seems to be following the directives from the readme. The tests are failing unexpectedly and I don't know how to fix them. @kairu-ms please help me try and get the tests to succeeded. I think there are several things wrong. The first thing that goes wrong is a JSON parsing exception. |
memontic-ms
force-pushed
the
communication-ga-release
branch
from
2b30be3 to
c72b4cd
Compare
|
@memontic-ms I've created a PR which fix your issues FYI df10f95 |
memontic-ms
force-pushed
the
communication-ga-release
branch
from
c72b4cd to
1a1db03
Compare
Manually updates: Test fixes Add test recordings Update version number Update help Update README Update HISTORY
memontic-ms
force-pushed
the
communication-ga-release
branch
from
5bd929a to
61e4bce
Compare
4 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.