{AKS} Update region mapping list for Container Insights to include la test regions#2846
Merged
fengzhou-msft merged 3 commits intoAzure:masterfrom Feb 17, 2021
bragi92:master
Merged
{AKS} Update region mapping list for Container Insights to include la test regions#2846fengzhou-msft merged 3 commits intoAzure:masterfrom bragi92:master
fengzhou-msft merged 3 commits intoAzure:masterfrom
bragi92:master
Conversation
Collaborator
|
AKS |
Member
Author
Member
Author
|
@fengzhou-msft Please take a look at this PR when you get a chance, it is ready for review. |
Member
Author
|
@fengzhou-msft This PR is on hold, We're having an internal conversation between teams to bring consistency to the short code usage. I'll update this with the final shortcodes once we have a consensus. |
ganga1980
approved these changes
Jan 15, 2021
Member
Author
|
@fengzhou-msft This is the same as the following PR-> Azure/azure-cli#16560 that got merged in the main az-cli repo for updating the regions. Please approve this when you get a chance. |
Member
Author
|
@fengzhou-msft This PR is ready for review and merge! |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@bragi92 can you merge the latest master branch to resolve the CI failure caused by another extension? |
Member
Author
|
@fengzhou-msft Updated, the build errors have been resolved. |
Member
Author
|
@fengzhou-msft This PR is ready for merge. |
fengzhou-msft
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.